[WIP] Luigi pipeline update #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorshi
commented
Jul 21, 2021
|
Added NSynth pitch dataset with the new builder method |
jorshi
commented
Jul 21, 2021
heareval/tasks/nsynth_pitch.py
Outdated
|
|
||
| # Filter out pitches that are not within the range of a standard piano | ||
| metadata = metadata[metadata["pitch"] >= 21] | ||
| metadata = metadata[metadata["pitch"] <= 108] |
There was a problem hiding this comment.
Make these config per @khumairraj's suggestion
There was a problem hiding this comment.
Yes. Maybe we can define it in the NsynthPitchConfig after the super(). Basically, everything in the super is something that is required across all datasets. Any config specific to the dataset can be after the super. Mostly such a kind of config attribute will be affecting the ConfigureProcessMetadata like this pitch thing.
jorshi
commented
Jul 21, 2021
jorshi
commented
Jul 21, 2021
turian
reviewed
Jul 21, 2021
khumairraj
reviewed
Jul 22, 2021
Comment on lines
+87
to
+91
| task_class = new_class( | ||
| name=name, | ||
| bases=(base,), | ||
| exec_body=partial(self.add_requirements, requirements), | ||
| ) |
khumairraj
approved these changes
Jul 22, 2021
jorshi
commented
Jul 22, 2021
| # train: 85,111; valid: 10,102; test: 4890. These values will be a bit less | ||
| # after filter the pitches to be only within the piano range. | ||
| # To subsample a partition, set the max_files to an integer. | ||
| # TODO: Should we subsample NSynth? |
There was a problem hiding this comment.
Full nsynth is quite large. Should we subsample it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea for updating the config and creating a more generic pipeline that can run based on the config files. To help keep the config files consistent I made them python classes -- these can be instantiated / modified by json in the future if we want.