Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Luigi pipeline update #78
[WIP] Luigi pipeline update #78
Changes from 19 commits
17dd7bd
ec435fe
e0bbce0
e7799f7
fa4f90b
04c8604
e9b14e3
1feb45b
518ebfc
46c3d8a
94ae944
bd1a729
c7fc530
6d7fb68
c4c05e6
c6591ff
56cda4c
998acd0
b7a01b2
fe76e96
b2b3f56
8ac1c0e
d419651
2bd7ffb
32a1933
01ba125
d8f5ef1
63b3d29
eb65831
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make these config per @khumairraj's suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Maybe we can define it in the
NsynthPitchConfig
after thesuper()
. Basically, everything in the super is something that is required across all datasets. Any config specific to the dataset can be after the super. Mostly such a kind of config attribute will be affecting theConfigureProcessMetadata
like this pitch thing.