cmake: Bump CMake minimum required version up to 3.22 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump CMake minimum required version up to 3.22
CMake 3.19: - The CMAKE_<LANG>_COMPILER variable may now be used to store "mandatory" compiler flags like the CC and other environment variables. CMake 3.21: - The Makefile Generators and the Ninja generator learned to add linker launcher tools along with the linker for C, CXX, OBJC, and OBJCXX languages.
CMake 3.17: - The FindPkgConfig module now extracts include directories prefixed with -isystem into the *_INCLUDE_DIRS variables and INTERFACE_INCLUDE_DIRECTORIES target properties.
CMake 3.20: - The configure_file() command gained FILE_PERMISSIONS options to support using specified permissions.
CMake 3.17: - The CMAKE_CURRENT_FUNCTION variable is now defined inside a function().
Deprecated since CMake 3.20.
CMake 3.21: - cmake gained the --toolchain command-line option to specify a toolchain file.
|
Concept ACK :) |
|
Guix build: |
There was a problem hiding this comment.
Concept ACK
I'll perform a cross-build later today, especially due to the removal of the workaround on commit ae5bd32 (cmake/module/CrossPkgConfig.cmake) not being necessary anymore (even CIs indicate to work fine).
pablomartin4btc
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
tACK a6a746e
Cross-building for Windows on Ubuntu 22.04 & Ubuntu 22.04 on WSL.
Ran successfully ctest and test_bitcoin-qt on both WSL and Windows 11 Pro.
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 21, 2024
Matches hebasto#123. This also also dev/ci only code.
|
ACK on bumping the version. I haven't yet looked at the all the cleanups. |
maflcko
reviewed
Mar 21, 2024
| # Centos Stream 8, EOL in May 2024: | ||
| # - CMake 3.20.2, http://mirror.centos.org/centos/8-stream/AppStream/x86_64/os/Packages/ | ||
| # Centos Stream 9, EOL in May 2027: | ||
| # - CMake 3.26.5, https://mirror.stream.centos.org/9-stream/AppStream/x86_64/os/Packages/ |
There was a problem hiding this comment.
lgtm. Confirmed in a docker:
# dnf install cmake
CentOS Stream 9 - BaseOS 2.8 MB/s | 8.0 MB 00:02
CentOS Stream 9 - AppStream 5.1 MB/s | 19 MB 00:03
CentOS Stream 9 - Extras packages 17 kB/s | 16 kB 00:00
Last metadata expiration check: 0:00:01 ago on Thu Mar 21 18:14:38 2024.
Dependencies resolved.
==============================================================================================================================================================================================================================================
Package Architecture Version Repository Size
==============================================================================================================================================================================================================================================
Installing:
cmake x86_64 3.26.5-2.el9 appstream 8.7 M
vasild
approved these changes
Mar 22, 2024
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Mar 22, 2024
Matches hebasto#123. This also also dev/ci only code.
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Mar 25, 2024
11ee058 tidy: remove C compiler check (fanquake) c3a4ea1 tidy: set CMAKE_CXX_STANDARD to 20 (fanquake) 5b690ae tidy: remove terminfo TODO (fanquake) 24410e5 tidy: set minimum CMake to 3.22 (fanquake) Pull request description: See hebasto#123 for the minimum version bump. ACKs for top commit: hebasto: re-ACK 11ee058. Tree-SHA512: 94a508ea24bf17919961bbdbc2e9d17658858e179c3b2017d5932557af32530d9d6aab197453aa5444f5478c417129c5a8e39522ff82bafac0d5a6966c7246d3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering the time when the new CMake-based build system will be available for users and bitcoin#29091, it seems reasonable to drop support for CMake versions older than 3.22.
For CMake version availability, please refer to https://repology.org/project/cmake/versions.
If an OS has no supported CMake in its system/default package manager, the user is still able to download it from https://cmake.org/download//
Please refer to commit messages for detailed explanations of code changes.