tidy: remove todo, set minimum CMake to 3.22 #29696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
Concept ACK, obviously :) |
hebasto
reviewed
Mar 22, 2024
Matches hebasto#123. This also also dev/ci only code.
fanquake
force-pushed
the
clang_tidy_todo
branch
from
e1d29dd
to
cf98578
Compare
At the same time, also disable searching for CURL, LibEdit, LibXml2, ZLIB and zstd none of which we use.
fanquake
force-pushed
the
clang_tidy_todo
branch
from
cf98578
to
5b690ae
Compare
Added LibXml2 while we are at it. |
|
Maybe also disable unneeded C compiler check: --- a/contrib/devtools/bitcoin-tidy/CMakeLists.txt
+++ b/contrib/devtools/bitcoin-tidy/CMakeLists.txt
@@ -1,6 +1,10 @@
cmake_minimum_required(VERSION 3.9)
-project(bitcoin-tidy VERSION 1.0.0 DESCRIPTION "clang-tidy checks for Bitcoin Core")
+project(bitcoin-tidy
+ VERSION 1.0.0
+ DESCRIPTION "clang-tidy checks for Bitcoin Core"
+ LANGUAGES CXX
+)
include(GNUInstallDirs)
? |
Also requires disabling FFI.
That works, but only after also disabling FFI. |
hebasto
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See hebasto#123 for the minimum version bump.