cmake: Port changes from PR28981 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport changes from bitcoin#28981.
hebasto
force-pushed
the
240418-cmake-DO
branch
from
ea7e4a2
to
b8fd285
Compare
hebasto
changed the title
laanwj
reviewed
Apr 24, 2024
| AUTO | ||
| ) | ||
| cmake_dependent_option(WITH_EXTERNAL_SIGNER "Enable external signer support." ON "NOT WIN32" OFF) | ||
| set(ENABLE_EXTERNAL_SIGNER ${WITH_EXTERNAL_SIGNER}) |
There was a problem hiding this comment.
Why this set? Is it just because the option name and the internal name are different?
There was a problem hiding this comment.
Correct. See:
bitcoin/cmake/bitcoin-config.h.in
Lines 145 to 146 in b8fd285
laanwj
reviewed
Apr 24, 2024
| @@ -55,54 +55,4 @@ function(add_boost_if_needed) | |||
| endif() | |||
| endif() | |||
|
|
|||
| if(WITH_EXTERNAL_SIGNER) | |||
laanwj
approved these changes
Apr 24, 2024
TheCharlatan
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
#154 (comment) this is unfortunate, but I think aligning the naming is something that should be done in another PR in concert with the other options.
LGTM ACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports changes from bitcoin#28981.