[TEST] Seven commits a top of the current default branch #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
force-pushed
the
230915-each-commit.MERGED
branch
from
4cbaf5b
to
5c7cdda
Compare
hebasto
added a commit
that referenced
this pull request
Jul 22, 2024
4d77971 fixup! cmake: Create test suite for `ctest` (Hennadii Stepanov) 16ac373 fixup! cmake: Build `test_bitcoin` executable (Hennadii Stepanov) Pull request description: CMake allows to report about skipped tests properly instead of passing dummy test cases. For instance, on Windows: ``` > ctest --build-config Release -R compilerbug Test project C:/Users/hebasto/source/repos/bitcoin/build Start 26: compilerbug_tests 1/1 Test #26: compilerbug_tests ................***Skipped 0.02 sec 100% tests passed, 0 tests failed out of 1 Total Test time (real) = 0.04 sec The following tests did not run: 26 - compilerbug_tests (Skipped) ``` We have 3 such cases: - `src/test/compilerbug_tests.cpp` - `src/test/raii_event_tests.cpp` - `src/test/system_tests.cpp` This PR handles the first two cases. Once bitcoin#30454 is merged, the following lines can be deleted: https://github.com/hebasto/bitcoin/blob/9b4aa929b0e84e64472402e594ebb13648bac878/src/test/system_tests.cpp#L19-L25 Top commit has no ACKs. Tree-SHA512: e4be4fd2469163fa4b3a36afb90f6186204f0151f668490305b6a7e632a6922cc4982233a6fc4bf2b1f7049658b42916a20e766197969aedd28f2eb097c4674d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.