cmake: Amend docs per feedback #316
Conversation
A few amendment to fuzzing.md 1. Removed non-portable $(nproc), mirrors the master branch. 2. Removed stray back slash. 3. Added a linker workaround for macOS.
|
cc @dergoegge @m3dwards @paplorinc |
| @@ -150,6 +150,7 @@ $ cmake -B build_fuzz \ | |||
| -DCMAKE_CXX_COMPILER="$(brew --prefix llvm)/bin/clang++" \ | |||
| -DBUILD_FOR_FUZZING=ON \ | |||
| -DSANITIZERS=undefined,address,fuzzer \ | |||
| -DAPPEND_LDFLAGS=-Wl,-no_warn_duplicate_libraries | |||
There was a problem hiding this comment.
Reading the thread from the other PR, it's not clear if there is an upstream issue open, or someone is going to open one. I see links to other discussions that look similar, but from what I can tell, aren't our issue.
| @@ -171,9 +172,9 @@ $ cmake -B build_fuzz \ | |||
| -DCMAKE_C_COMPILER="$(pwd)/AFLplusplus/afl-clang-lto" \ | |||
| -DCMAKE_CXX_COMPILER="$(pwd)/AFLplusplus/afl-clang-lto++" \ | |||
| -DBUILD_FOR_FUZZING=ON | |||
| $ cmake --build build_fuzz -j$(nproc) | |||
| $ cmake --build build_fuzz | |||
There was a problem hiding this comment.
I haven't tried these, it's possible that these might also need a -no_warn_duplicate_libraries, right?
| @@ -14,7 +14,7 @@ $ cmake -B build_fuzz \ | |||
| -DSANITIZERS=undefined,address,fuzzer | |||
| # macOS users: If you have problem with this step then make sure to read "macOS hints for | |||
| # libFuzzer" on https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md#macos-hints-for-libfuzzer | |||
| $ cmake --build build_fuzz -j$(nproc) | |||
There was a problem hiding this comment.
it seems to me we should likely update https://github.com/bitcoin/bitcoin/blob/19f0dd02c1373dd9d2241ce25cbbcb6831763725/doc/developer-notes.md?plain=1#L224 and https://github.com/bitcoin/bitcoin/blob/14093d5d243f6eb9cfef721c80f92848d95032ee/doc/productivity.md?plain=1#L63-L69 as well (both to cmake and the nproc reference)
| @@ -150,6 +150,7 @@ $ cmake -B build_fuzz \ | |||
| -DCMAKE_CXX_COMPILER="$(brew --prefix llvm)/bin/clang++" \ | |||
| -DBUILD_FOR_FUZZING=ON \ | |||
| -DSANITIZERS=undefined,address,fuzzer \ | |||
| -DAPPEND_LDFLAGS=-Wl,-no_warn_duplicate_libraries | |||
|
ACK 7c37119 |
A few amendments to the
fuzzing.md:Also a "TODO" prefix has been added to the comment.