Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

&mut wgpu::Device does not have to be mutable #26

Closed
Technici4n opened this issue Nov 25, 2019 · 2 comments
Closed

&mut wgpu::Device does not have to be mutable #26

Technici4n opened this issue Nov 25, 2019 · 2 comments
Labels
question Further information is requested

Comments

@Technici4n
Copy link

I think that all mutable references to wgpu::Device can be replaced by immutable references, considering that wgpu::Device has no &mut self function. Do you think this could be changed?
I can submit a PR myself if you want me to.

Thanks
@hecrj
Copy link
Owner

hecrj commented Dec 1, 2019

Yes, that is true. #12 was a similar issue.

Is the mutability requirement an issue for your use case?

@hecrj hecrj added the question Further information is requested label Dec 1, 2019
@Technici4n
Copy link
Author

Ah yes it makes sense. No, it's not an issue, it was just a bit... surprising!

@hecrj hecrj mentioned this issue Dec 15, 2019
Merged
@hecrj hecrj mentioned this issue Dec 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hecrj @Technici4n