Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support transformers 0.4 #150

Merged
merged 2 commits into from
Feb 4, 2018
Merged

Support transformers 0.4 #150

merged 2 commits into from
Feb 4, 2018

Conversation

gwils
Copy link
Contributor

@gwils gwils commented Feb 2, 2018

Here's some CPP to support transformers 0.4. This should help some users using GHC 7.10 since transformers 0.4 is a boot library on that version.

@gwils gwils mentioned this pull request Feb 3, 2018
Merged
@gwils
Copy link
Contributor Author

gwils commented Feb 3, 2018

Supporting boot libraries for a given GHC version is A Good Thing because any user who depends on ghc-the-library will be forced to use those versions. So at the moment nobody on GHC 7.10.3 who depends on the ghc library will be able to use hedgehog, which is a shame.

I think this CPP is a small price to pay to make the library a bit more widely usable, even if it will only affect a handful of users. For example ghc-mod depends on ghc and supports 7.10.3, so ghc-mod or anything that depends on it cannot be tested with hedgehog without this PR.

@gwils
Copy link
Contributor Author

gwils commented Feb 3, 2018

I've just learnt that doctest also depends on the ghc library.
Hence, anyone who wants to support GHC 7.10.3 cannot use both doctest and hedgehog.
This is because doctest would force the boot library versions for the present GHC, which in the case of 7.10.3, would violate hedgehog's lower bound transformers >= 0.5

I would expect hedgehog wishes to cooperate well with other testing libraries, so I think this is now an easier choice.
I'm happy to maintain the CPP by the way, if you're concerned about maintenance going forward.

@thumphries
Copy link
Member

This seems totally reasonable to me, we claim to support 7.10 and should aim to maximise compatibility for users of supported releases.

Let's get the build green first and go from there

@gwils
Copy link
Contributor Author

gwils commented Feb 4, 2018

One of the jobs failed because it went for 10 minutes without output while running the tests. This seems to happen occasionally with both the mafia-based travis setup and the new-build based one.

Over in #149 I've fixed it by inserting a call to travis_wait. For now, if you restart that specific job, it should hpoefully go green.

@thumphries
Copy link
Member

Have rebased this and will merge on green

@gwils
Set INTSALLED back to true
5bac83a 
Now that transformers 0.4 works we can set INSTALLED to true in the
travis config, which will make cabal pick GHC boot library versions
of dependencies.

It's a bit stricter of a check way, and ensures we work with
libraries that depend on ghc-the-library, such as doctest or ghc-mod.
@gwils
Copy link
Contributor Author

gwils commented Feb 4, 2018

I've added a commit to set INSTALLED back to true in the travis config, so travis should now verify that we work with the ghc boot library versions of dependencies.

@gwils gwils mentioned this pull request Feb 4, 2018
Merged
@thumphries thumphries merged commit 62617ab into hedgehogqa:master Feb 4, 2018
@gwils gwils deleted the transformers-0.4 branch February 4, 2018 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gwils @thumphries