-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support transformers 0.4 #150
Conversation
Supporting boot libraries for a given GHC version is A Good Thing because any user who depends on ghc-the-library will be forced to use those versions. So at the moment nobody on GHC 7.10.3 who depends on the ghc library will be able to use hedgehog, which is a shame. I think this CPP is a small price to pay to make the library a bit more widely usable, even if it will only affect a handful of users. For example ghc-mod depends on ghc and supports 7.10.3, so ghc-mod or anything that depends on it cannot be tested with hedgehog without this PR. |
I've just learnt that doctest also depends on the ghc library. I would expect hedgehog wishes to cooperate well with other testing libraries, so I think this is now an easier choice. |
This seems totally reasonable to me, we claim to support 7.10 and should aim to maximise compatibility for users of supported releases. Let's get the build green first and go from there |
One of the jobs failed because it went for 10 minutes without output while running the tests. This seems to happen occasionally with both the mafia-based travis setup and the new-build based one. Over in #149 I've fixed it by inserting a call to |
b6d8728
to
bf569ab
Compare
bf569ab
to
e9c1d99
Compare
Have rebased this and will merge on green |
Now that transformers 0.4 works we can set INSTALLED to true in the travis config, which will make cabal pick GHC boot library versions of dependencies. It's a bit stricter of a check way, and ensures we work with libraries that depend on ghc-the-library, such as doctest or ghc-mod.
I've added a commit to set INSTALLED back to true in the travis config, so travis should now verify that we work with the ghc boot library versions of dependencies. |
Here's some CPP to support transformers 0.4. This should help some users using GHC 7.10 since transformers 0.4 is a boot library on that version.