Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless dependency #1

Closed
seaneble opened this issue Aug 18, 2015 · 2 comments
Closed

Useless dependency #1

seaneble opened this issue Aug 18, 2015 · 2 comments

Comments

@seaneble
Copy link

There is a discrepancy between composer and the autoloader configuration:

https://github.com/heimrichhannot/contao-member_plus/blob/master/config/autoload.ini#L4
https://github.com/heimrichhannot/contao-member_plus/blob/master/composer.json#L21

I don't see any hard dependency of this module to contao-formhybrid, so I suggest you drop the require in composer.json. It leads to quite a lot of additional modules being installed, like extcss. If there is some kind of technical reason for this, I recommend moving the shared code to a common library used by both modules.

@fatcrobat
Copy link

Formhybrid dependency is required by member_plus registration plus module. But we removed the bootstrapper dependendy within heimrichhannot/contao-formhybrid#1

@seaneble
Copy link
Author

Okay, I looked at it from the wrong side. But it still makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants