Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated selector in gloom/index.less #2

Closed
LorenzoPane opened this issue Jan 11, 2017 · 1 comment
Closed

Deprecated selector in gloom/index.less #2

LorenzoPane opened this issue Jan 11, 2017 · 1 comment
Labels

Comments

@LorenzoPane
Copy link

LorenzoPane commented Jan 11, 2017

In gloom/index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

  • atom-text-editor, :host => atom-text-editor,atom-text-editor

  • atom-text-editor .gutter, :host .gutter => atom-text-editor .gutter,atom-text-editor .gutter

  • atom-text-editor .gutter .line-number.cursor-line, :host .gutter .line-number.cursor-line => atom-text-editor .gutter .line-number.cursor-line,atom-text-editor .gutter .line-number.cursor-line

  • atom-text-editor .gutter .line-number.cursor-line-no-selection, :host .gutter .line-number.cursor-line-no-selection => atom-text-editor .gutter .line-number.cursor-line-no-selection,atom-text-editor .gutter .line-number.cursor-line-no-selection

  • atom-text-editor .wrap-guide, :host .wrap-guide => atom-text-editor .wrap-guide,atom-text-editor .wrap-guide

  • atom-text-editor .indent-guide, :host .indent-guide => atom-text-editor .indent-guide,atom-text-editor .indent-guide

  • atom-text-editor .invisible-character, :host .invisible-character => atom-text-editor .invisible-character,atom-text-editor .invisible-character

  • atom-text-editor .search-results .marker .region, :host .search-results .marker .region => atom-text-editor .search-results .syntax--marker .region,atom-text-editor .search-results .syntax--marker .region

  • atom-text-editor .search-results .marker.current-result .region, :host .search-results .marker.current-result .region => atom-text-editor .search-results .syntax--marker.current-result .region,atom-text-editor .search-results .syntax--marker.current-result .region

  • atom-text-editor.is-focused .cursor, :host(.is-focused) .cursor => atom-text-editor.is-focused .cursor,atom-text-editor .cursor

  • atom-text-editor.is-focused .selection .region, :host(.is-focused) .selection .region => atom-text-editor.is-focused .selection .region,atom-text-editor .selection .region

  • atom-text-editor.is-focused .line-number.cursor-line-no-selection, atom-text-editor.is-focused .line.cursor-line, :host(.is-focused) .line-number.cursor-line-no-selection, :host(.is-focused) .line.cursor-line => atom-text-editor.is-focused .line-number.cursor-line-no-selection, atom-text-editor.is-focused .line.cursor-line,atom-text-editor .line-number.cursor-line-no-selection,atom-text-editor .line.cursor-line

  • atom-text-editor::shadow .bracket-matcher .region => atom-text-editor.editor .bracket-matcher .region

  • .comment => .syntax--comment

  • .string => .syntax--string

  • .constant.numeric => .syntax--constant.syntax--numeric

  • .constant.language, .constant.character, .constant.other => .syntax--constant.syntax--language, .syntax--constant.syntax--character, .syntax--constant.syntax--other

  • .variable => .syntax--variable

  • .keyword => .syntax--keyword

  • .storage => .syntax--storage

  • .storage.type => .syntax--storage.syntax--type

  • .entity.name.class => .syntax--entity.syntax--name.syntax--class

  • .entity.other.inherited-class => .syntax--entity.syntax--other.syntax--inherited-class

  • .entity.name.function => .syntax--entity.syntax--name.syntax--function

  • .variable.parameter => .syntax--variable.syntax--parameter

  • .entity.name.tag => .syntax--entity.syntax--name.syntax--tag

  • .entity.other.attribute-name => .syntax--entity.syntax--other.syntax--attribute-name

  • .support.function, .support.constant => .syntax--support.syntax--function, .syntax--support.syntax--constant

  • .support.type, .support.class => .syntax--support.syntax--type, .syntax--support.syntax--class

  • .invalid, .invalid.deprecated => .syntax--invalid, .syntax--invalid.syntax--deprecated

  • .invalid.deprecated => .syntax--invalid.syntax--deprecated

Automatic translation of selectors will be probably automatically removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

@hejrobin
Copy link
Owner

I'll look in to this this weekend. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants