This repository has been archived by the owner on Jul 6, 2023. It is now read-only.
Update Release 3 to Release 3.1 #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a path with an illegal id is provided by the caller (something that does not match the regexp), the Gorilla Mux Router automatically routed the call to http.NotFoundHandler(). This would be ok for an API to handle, but the heketi-cli would output information which was not very human friendly. Instead, we now provide our own error handler which returns a nicer error than just "404: Not found". Closes heketi#539 Signed-off-by: Luis Pabón <lpabon@redhat.com>
This enables external Golang projects to easily create Heketi server for their unit tests. Signed-off-by: Luis Pabón <lpabon@redhat.com>
Signed-off-by: Luis Pabón <lpabon@redhat.com>
api: Better invalid path error handler
Signed-off-by: Luis Pabón <lpabon@redhat.com>
Update python client version
Heketi unit test server for external projects
Signed-off-by: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
Currently, the go build tool passes -z relro to the linker, which creates a 'partial' RELRO executable. Maybe it is a bug in the GNU linker, but '-z relro' only creates a partial RELRO. For a full RELRO to be created the switch '-z now' must also be passed. See http://tk-blog.blogspot.com/2009/02/relro-not-so-well-known-memory.html for more information. Signed-off-by: Luis Pabón <lpabon@redhat.com>
modified setup.py for pypi and wheel distributions
build: Support full RELRO
Makefile: Update to add kubernetes files in client package
Update minikube to 1.2.0, docker-machine to 0.8.2, and kubernetes to v1.4.3 Closes heketi#557 Signed-off-by: Luis Pabón <lpabon@redhat.com>
tests: Update to Kubernetes to v1.4.3
This change fixes some of the issues in the Kubernetes deployment, and adds the topology sample file to the distribution Signed-off-by: Luis Pabón <lpabon@redhat.com>
Kubernetes deployment fixes
Typo and template fix for README.md
Add proper deploy-heketi label to the deploy-heketi Deployment.
Update deploy-heketi-deployment.json
Instead of asking the user for the namespace, Heketi can read the namespace location from the service account secret. Signed-off-by: Luis Pabón <lpabon@redhat.com>
kubernetes: Use namespace from secret
Signed-off-by: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>
Kubernetes Deployment: Changes based on Kubernetes Integration
|
dang, again failed centos-ci: |
|
Is that flakey? |
|
FYI, the failure is in the minikube tests: |
|
@lpabon where do you see that minikube error? All I see when I navigate to the centos-ci and click on console output (https://ci.centos.org/job/gluster_heketi-functional/128/console) is the error i pasted above... |
|
ok, i see it in the plain text output https://ci.centos.org/job/gluster_heketi-functional/128/consoleText but what does that error mean. how can we resolve that? |
|
Merged according to @lpabon 's recommendation to ignore this minikube error. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.