Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for 1.7.0 fails with go 1.18 #20

Closed
gblues opened this issue Apr 4, 2022 · 2 comments
Closed

Build for 1.7.0 fails with go 1.18 #20

gblues opened this issue Apr 4, 2022 · 2 comments

Comments

@gblues
Copy link

gblues commented Apr 4, 2022

Bug Report

git-team version: 1.7.0
go version: 1.18

failure description

When attempting to install git-team via homebrew, the go build step fails because of outdated dependencies.

expected behaviour description

git-team should install successfully

While installing with --HEAD works, it also brings in other code changes.

proposed workaround:

  1. create a new branch off the v1.7.0 commit
  2. apply this patch, which fixes the build issues
  3. tag the commit with v1.7.1
  4. update the homebrew formula to v1.7.1
  5. on the main branch, bump the dev version up to 1.7.2-alpha1 or whatever
@hekmekk
Copy link
Owner

hekmekk commented Apr 13, 2022

Thank you for bringing this up @gblues and sorry for the late reply. Will look into this as soon as possible.

@hekmekk
Copy link
Owner

hekmekk commented Apr 13, 2022

This commit should resolve the issue for now and reflect the current state of the project.

@hekmekk hekmekk closed this as completed Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants