Using sort: 'text' doesn't retain proper order

[troywoy]

While the title may not make sense, I hope that the details here make it crystal clear.

When creating a tree with sort: 'text' applied to the configuration and supplying data in an array that is out of order, keyboard navigation (more specifically nextVisibleNode, previousVisibleNode, etc) fails to return the proper node.

Consider this configuration:

var tree = new InspireTree({
    target: '.tree',
    sort: 'text',
    data: [{
        text: 'A',
    }, {
        text: 'C'
    }, {
        text: 'B'
    }]
});

Then tree.nodes()[1] would give me node B, however calling tree.nodes()[1].nextVisibleNode() would give me undefined since it was last in the original data array. I would expect that to give me C since it's visually the next one.

I can create a JSFiddle if you have trouble recreating this.

[troywoy]

Well that's frustrating, I might've put my foot in my mouth. I made this fiddle, which contradicts the issue I've filed.

The only difference I have between my issue and the fiddle is that I'm using a custom Angular renderer.

Thoughts?

PS: Sorry the fiddle is ugly, I don't know a better way to include libraries that aren't available over a CDN.

[troywoy]

Alright, I was able to recreate it in this fiddle using my test data. Apparently sort: 'text' has nothing to do with this (I was making an assumption, sorry).

If you expand all nodes and move down the tree with the down arrow, you get stuck on Rodger Federer. If you move up the tree, it skips the children of Tennis entirely. If you collapse Tennisthen you can traverse up and down without issue. Not sure what the issue is here anymore, but at least I have a "broken" scenario for you.

[viveleroi]

Both "broken" and "working" examples fail for me, but I see why these aren't working. I can have a fix tomorrow morning.

[viveleroi]

I have a fix for this in place. Just need to write some tests tomorrow.

Also, I've requested that inspire-tree be included in the cdnjs.com library. That way you have a cdn url to the files you can link to in jsbin/fiddle demos.

[troywoy]

Yeah I didn't name those properly. Both were broken, I just wanted to ensure data that wasn't in the proper order was the root cause.

[onack]

I have the same issue with 1.10.3 if I add elements after tree is initialized

Example: https://jsfiddle.net/3v5wL01u/1/

[viveleroi]

@onack I've moved your issue to #78 because while it involves sorting, it's unrelated to this issue.