-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIP26: Payment Notes #125
Comments
This functionality is essential to implement imo (to mitigate harassment/spam). |
With support for memos in |
Looks good to me. I'll defer to the HIP author @cvolkernick as far as closing this particular HIP vs. accepting this implementation vs. keeping this HIP open to invite a competing implementation. helium/blockchain-core#768 is different from the HIP, but that is exactly what is supposed to happen during product development. IMHO 768 seems to balance blockchain efficiency with the more abstract goal of attaching identiifiers to payments, and the actual text of the "host-to-host messaging" could be implemented off-chain. That would also allow for more flexible options for identity and encryption. |
Sounds reasonable to me, the blockchain core change seems to be fundamentally enabling the intent behind the HIP. It was never written with any particular implementation in mind, only to spur discussion. |
Curious if we consider this closed now that memos have been implemented on chain and other apps can use memos to build more fully featured host to host messaging. cc: @cvolkernick @jamiew |
Will stand by my previous response from 4/8. Worst case another HIP can be drafted if things don't pan out as intended/desired. Thanks to the development team for the implementation. |
Propose closing this @jamiew? |
Marked Deployed. This is considered addressed by the addition of Acceptance block: |
Author(s): @cvolkernick
Initial PR: #117
Start Date: 2021-01-24
Category: Technical
Rendered view:
https://github.com/helium/HIP/blob/master/0026-payment-notes.md
Summary:
This proposal suggests the addition of a new option for the Helium wallet PAY command: an optional (likely length/size restricted) alphanumeric memo/note field included with a wallet-to-wallet HNT payment transaction.
The text was updated successfully, but these errors were encountered: