fix(dap): validate key and index exist when requesting vars #5628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipdutescu
force-pushed
the
fix/dap_list_variables_boundaries
branch
from
b2cf135
to
24ca949
Compare
the-mikedavis
added
C-bug
filipdutescu
force-pushed
the
fix/dap_list_variables_boundaries
branch
from
24ca949
to
c31fc15
Compare
archseer
reviewed
Jan 22, 2023
filipdutescu
force-pushed
the
fix/dap_list_variables_boundaries
branch
from
c31fc15
to
66a2a8f
Compare
filipdutescu
force-pushed
the
fix/dap_list_variables_boundaries
branch
from
66a2a8f
to
00eaaa6
Compare
Check if the stack frames contain the thread id and the frame before trying to get the frame id. If case any of the two fails to be found, provide the user with messages to inform them of the issue and gracefully return. Closes: helix-editor#5625 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
archseer
approved these changes
Feb 20, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
…itor#5628) Check if the stack frames contain the thread id and the frame before trying to get the frame id. If case any of the two fails to be found, provide the user with messages to inform them of the issue and gracefully return. Closes: helix-editor#5625 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the stack frames contain the thread id and the frame before trying to get the frame id. If case any of the two fails to be found, provide the user with messages to inform them of the issue and gracefully return.
Closes: #5625
Signed-off-by: Filip Dutescu filip.dutescu@gmail.com