Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use helix logo as icon for the hx executable 😋 #5940

Closed
goyalyashpal opened this issue Feb 12, 2023 · 11 comments · Fixed by #9104
Closed

Use helix logo as icon for the hx executable 😋 #5940

goyalyashpal opened this issue Feb 12, 2023 · 11 comments · Fixed by #9104
Labels
C-enhancement Category: Improvements

Comments

@goyalyashpal
Copy link
Contributor

Helix logo as icon file

  • Is the icon file (not png image) for the new helix logo shared anywhere here on github repo or in the binary?
  • as i found that shortcut suggestion to be really effective,
  • and having the nice helix logo as the icon will be aweome.

Proposal

  • Can that icon be put on the hx executable file too?
  • I know that TUI exe files don't have any icon (and understandably too) but i'd say it doesn't hurt to have it there or does it?

in hx 22.12 the icon for exe is this: doublecmd_VPMBhqyHf3

Screenshots

@goyalyashpal goyalyashpal added the C-enhancement Category: Improvements label Feb 12, 2023
@goyalyashpal
Copy link
Contributor Author

  • I tried changing the icon for that shortcut file, but it still shows the wezterm icon in the start menu.
  • wezterm - that's the program which is the shortcut points to...

So, it may not be possible to use the icon to shortcut after all - even despite using it for the .exe file.

@goyalyashpal goyalyashpal closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2023
@goyalyashpal
Copy link
Contributor Author

Anyways: for those interested:

  • here's the .ico file in square proportions i created using GIMP
  • It's 24 bit with alpha (i.e. the alpha is one bit) not 32-bit.

It looks really nice. really, so many people pitched in and the gradual blooming of the ideas for logo was nice to see.

image

Github wasn't allowing .ico files, so, i renamed to .png. Rename it back to .ico to use this:

helix-logo

@goyalyashpal goyalyashpal changed the title Use helix icon for the hx executable 😋 Use helix logo as icon for the hx executable 😋 Feb 12, 2023
@goyalyashpal
Copy link
Contributor Author

Here was some resources i found to add icons to executables:

@NewtonChutney
Copy link
Contributor

NewtonChutney commented Dec 16, 2023

So, it may not be possible to use the icon to shortcut after all - even despite using it for the .exe file.

Hey @goyalyashpal though the shortcut is out of scope of this project, I think the exe file produced ought to have this icon embedded in it.. could you reopen this issue?
There would be cases where hx.exe is directly pinned to start.. or launched in Win+R dialog box

@goyalyashpal goyalyashpal reopened this Dec 17, 2023
@archseer
Copy link
Member

The icon isn't showing up for you because your shortcut is calling wezterm which is then running helix (so wezterm is the program getting started). You can change the icon manually on your end but there's nothing else we can do. The icon is used in flatpak and some other packages from what I remember.

@goyalyashpal
Copy link
Contributor Author

@NewtonChutney does above addresses ur concern? be sure to inform - as i had already closed the issue on my end & have opened up only for u.

@NewtonChutney
Copy link
Contributor

NewtonChutney commented Dec 17, 2023

So, it may not be possible to use the icon to shortcut after all - even despite using it for the .exe file.

Hey @goyalyashpal though the shortcut is out of scope of this project, I think the exe file produced ought to have this icon embedded in it.. could you reopen this issue?
There would be cases where hx.exe is directly pinned to start.. or launched in Win+R dialog box

@archseer the main exe file in Windows doesn't have an icon..
Could that be fixed? When pinned to start, or set as a profile in Windows Terminal, we could use the inbuilt icon of the binary if it had one..

Nu has integrated the icon properly: and it is one program which is mostly launched as a Windows Terminal profile or in the Win+R dialog..
image

They seem to be using the wix installer toolset
https://github.com/nushell/nushell/blob/2264682443dcf926b2b5d0caee513bf12e501956/wix/main.wxs#L79

@NewtonChutney

This comment was marked as off-topic.

@archseer
Copy link
Member

hx is a terminal application and won't work if started directly I assume.

@NewtonChutney
Copy link
Contributor

NewtonChutney commented Dec 17, 2023

hx is a terminal application and won't work if started directly I assume.

😅 It does.. (gets opened in WT, instead of conhost)
I use it to traverse to my ssh config file everytime from the run dialog (win+r)

@NewtonChutney
Copy link
Contributor

Looks like this would better suit helix's build than nushell's wix toolset
https://github.com/mxre/winres

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants