-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trajectory management classes #106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hello-binit
force-pushed
the
feature/device_threading2
branch
from
October 4, 2021 21:37
e26f5f6
to
e1c5205
Compare
hello-binit
force-pushed
the
feature/traj_classes
branch
from
October 4, 2021 21:39
88e1c1b
to
9b33747
Compare
aedsinger
requested changes
Oct 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test_invalid_spline test fails for me (18.04/Py3).
Thanks, will look into it. Can you post the error log? |
hello-binit
force-pushed
the
feature/traj_classes
branch
from
October 5, 2021 05:10
9b33747
to
ae99d43
Compare
Should be fixed now. |
hello-binit
force-pushed
the
feature/traj_classes
branch
2 times, most recently
from
October 6, 2021 04:23
736305b
to
3ff2867
Compare
hello-binit
force-pushed
the
feature/traj_classes
branch
from
October 6, 2021 04:32
3ff2867
to
f24ea89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces trajectories.py, which defines classes that manage waypoint trajectories. There is
Waypoint
,Segment
,Spline
, which implements most of the rules around waypoints and how they work together. Then, there are subclassesPrismaticTrajectory
andRevoluteTrajectory
, which are intended to be used by the arm, lift, and dynamixel devices. A mobile base trajectory class will be added in a subsequent PR.Additionally, some of the functionality is broken out into hello_utils for higher level visualization and planning software to utilize. This includes
evaluate_polynomial_at
,is_segment_feasible
, andgenerate_<quintic/cubic/linear>_segment
s.Comprehensive tests are included in test_hello_utils.py and test_trajectories.py. These tests pass on Python2/3 Ubuntu 18.04.