Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trajectory management classes #106

Merged
merged 10 commits into from
Oct 6, 2021
Merged

Trajectory management classes #106

merged 10 commits into from
Oct 6, 2021

Conversation

hello-binit
Copy link
Contributor

@hello-binit hello-binit commented Oct 1, 2021

This PR introduces trajectories.py, which defines classes that manage waypoint trajectories. There is Waypoint, Segment, Spline, which implements most of the rules around waypoints and how they work together. Then, there are subclasses PrismaticTrajectory and RevoluteTrajectory, which are intended to be used by the arm, lift, and dynamixel devices. A mobile base trajectory class will be added in a subsequent PR.

Additionally, some of the functionality is broken out into hello_utils for higher level visualization and planning software to utilize. This includes evaluate_polynomial_at, is_segment_feasible, and generate_<quintic/cubic/linear>_segments.

Comprehensive tests are included in test_hello_utils.py and test_trajectories.py. These tests pass on Python2/3 Ubuntu 18.04.

@hello-binit hello-binit changed the title Feature/traj classes Trajectory management classes Oct 1, 2021
@hello-binit hello-binit marked this pull request as ready for review October 4, 2021 20:46
Copy link
Contributor

@aedsinger aedsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test_invalid_spline test fails for me (18.04/Py3).

@hello-binit
Copy link
Contributor Author

The test_invalid_spline test fails for me (18.04/Py3).

Thanks, will look into it. Can you post the error log?

Base automatically changed from feature/device_threading2 to develop October 4, 2021 23:11
@hello-binit
Copy link
Contributor Author

Should be fixed now.

@hello-binit hello-binit force-pushed the feature/traj_classes branch 2 times, most recently from 736305b to 3ff2867 Compare October 6, 2021 04:23
@hello-binit hello-binit merged commit 60a6f14 into develop Oct 6, 2021
@hello-binit hello-binit deleted the feature/traj_classes branch October 6, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants