Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added warning for homing offset on dxl #151

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

aedsinger
Copy link
Contributor

    Users may incorrectly set the homing offset on a single-turn servo
    In general on single-turn servos, the homing offset should be zero
    In some cases it may be non-zero but between -1024 and 1024 (per DXL spec)
    If it is outside of the valid range it is ignored. However,
    when the servo is placed in other control modes (eg vel) the reported encoder position start using the offset
    This can create unexpected behavior

This PR adds the above warning and checks for a bad homing offset.

@aedsinger aedsinger merged commit fd594ab into feature/mitski_pre_release Sep 8, 2022
@aedsinger aedsinger deleted the bugfix/bad_homing_offset branch September 8, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant