Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamixel and file bugs, add regression tests #24

Merged
merged 2 commits into from
May 24, 2021
Merged

Fix dynamixel and file bugs, add regression tests #24

merged 2 commits into from
May 24, 2021

Conversation

hello-binit
Copy link
Contributor

  • Dynamixel range is a tuple, so it can't be compared against an int
  • An open filed was never released
  • Regression tests introduced for both of these bugs

Tested on:

  • Python 3.8.5

@aedsinger aedsinger merged commit 567e42d into develop May 24, 2021
@aedsinger aedsinger deleted the bugfix/introduce_testing branch May 24, 2021 19:44
@hello-binit hello-binit mentioned this pull request May 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aedsinger aedsinger aedsinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hello-binit @aedsinger