fix issue where user soft limits overwritten by collision model #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RobotCollision class was setting the joint soft limits to 'None' (eg, physical hardstop) if the collision model didn't limit the range of motion. This had the side effect of overwriting an user limits set via the
set_soft_limit
API.This fix initializes the values of the collision system with the current values of each joint. This should resolve the issue. It hasn't yet been tested and requires a unittest.