Replace certificate creation scripts with standalone script #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hello-amal
approved these changes
Jul 10, 2024
| @@ -104,4 +92,4 @@ echo "Setup uncalibrated robot URDF..." | |||
| ros2 run stretch_calibration update_uncalibrated_urdf >> $REDIRECT_LOGFILE | |||
| echo "Setup calibrated robot URDF..." | |||
| ros2 run stretch_calibration update_with_most_recent_calibration >> $REDIRECT_LOGFILE | |||
| colcon build &>> $REDIRECT_LOGFILE | |||
| colcon build &>> $REDIRECT_LOGFILE | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the certification creation commands for the web teleop from the create ament_ws script and instead calls the
create_cerficates.shscript that should exist in the Stretch web teleop package directory. This PR needs to be coupled with this PR hello-robot/stretch_web_teleop#69 before merging.