Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings provided by clippy #2

Open
helloer opened this issue Mar 29, 2018 · 1 comment
Open

Fix warnings provided by clippy #2

helloer opened this issue Mar 29, 2018 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@helloer
Copy link
Owner

helloer commented Mar 29, 2018

https://github.com/rust-lang-nursery/rust-clippy

You have to run cargo clippy for soldank and gfx2d separately.
@helloer helloer added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 29, 2018
@urraka
Copy link
Collaborator

urraka commented Mar 30, 2018

Fixed all warnings except control.rs (and did some refactoring). There are a couple that might stay for a while:

  • soldier.update: the function has a cyclomatic complexity of 33
  • soldier.control: the function has a cyclomatic complexity of 164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@helloer @urraka