Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL's with GET parameters won't show as active #20

Closed
tony opened this issue Jul 24, 2017 · 4 comments
Closed

URL's with GET parameters won't show as active #20

tony opened this issue Jul 24, 2017 · 4 comments

Comments

@tony
Copy link
Collaborator

tony commented Jul 24, 2017

e.g. <a href="{% url 'account_login' %}?next={{request.get_full_path}}" won't show as active.

Solution: consider an option that chops off / ignores GET params around https://github.com/hellysmile/django-activeurl/blob/master/django_activeurl/utils.py#L79

@hellysmile
Copy link
Owner

Hey! It is on my roadmap for more then 1 year. Unforuannely I am not working with django full-time right now. Pull request are welcome to the refactoring branch. I ecpect to do this feature my own in 1.5 month during next vacation ;)

@hellysmile
Copy link
Owner

Btw, You can try this fork flaiming@6b6bc4d#diff-90af05de253ae0f93450449acf00552dR60

@tony
Copy link
Collaborator Author

tony commented Jul 24, 2017

I'm going to try a slightly different approach. A new param with a default value, rather than a setting.

Then I'm going to add a test for it and PR.

Re: flaiming@6b6bc4d#commitcomment-9649019

I'm going to do a first PR with re.sub w/ tests. Then we can figure out urlparse in a future PR

tony added a commit to develtech/django-activeurl that referenced this issue Jul 25, 2017
tony added a commit to develtech/django-activeurl that referenced this issue Jul 25, 2017
Also, decouple off yes/no functionality into ``yesno_to_bool`` function.
hellysmile added a commit that referenced this issue Jul 25, 2017
support for ignoring get params #20
@tony
Copy link
Collaborator Author

tony commented Jul 25, 2017

This is in now.

@tony tony closed this as completed Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants