-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL's with GET parameters won't show as active #20
Comments
Hey! It is on my roadmap for more then 1 year. Unforuannely I am not working with django full-time right now. Pull request are welcome to the refactoring branch. I ecpect to do this feature my own in 1.5 month during next vacation ;) |
Btw, You can try this fork flaiming@6b6bc4d#diff-90af05de253ae0f93450449acf00552dR60 |
I'm going to try a slightly different approach. A new param with a default value, rather than a setting. Then I'm going to add a test for it and PR. Re: flaiming@6b6bc4d#commitcomment-9649019 I'm going to do a first PR with |
Also, decouple off yes/no functionality into ``yesno_to_bool`` function.
support for ignoring get params #20
This is in now. |
e.g.
<a href="{% url 'account_login' %}?next={{request.get_full_path}}"
won't show as active.Solution: consider an option that chops off / ignores GET params around https://github.com/hellysmile/django-activeurl/blob/master/django_activeurl/utils.py#L79
The text was updated successfully, but these errors were encountered: