[stable/sonarqube] Duplicate scheduling settings in deployment.yaml template

[rustymunkey]

Describe the bug
The deployment.yaml file contains duplicate entries of the elements nodeSelector, hostAliases, tolerations and affinity. The problem is that the first occurence between L102 and L118 of these elements is right in the middle of the initContainer array.

This leads to a failed helm install when using for example affinity and the plugin install init container.

As the elements in question have their correct occurence between L239 and L251 it should be save to simply remove the first, incorrect ones.

A workaround is to remove the node scheduling settings from the values.yaml.

Which chart:
stable/sonarqube 3.2.7

What happened:
When using affinity and the plugin install init container, the chart installation fails with the message:

Failed to install app sonarqube. Error: YAML parse error on sonarqube/templates/deployment.yaml: error converting YAML to JSON: yaml: line 97: did not find expected key

Line 97 in my case was the duplicate entry of affinity

How to reproduce it (as minimally and precisely as possible):
I used the following values (among others):

  plugins:
    install:
      - "https://github.com/SonarSource/sonar-ldap/releases/download/2.2-RC3/sonar-ldap-plugin-2.2.0.601.jar"
  
  affinity:
    nodeAffinity:
      preferredDuringSchedulingIgnoredDuringExecution:
      - weight: 50
        preference:
          matchExpressions:
          - key: "node-role"
            operator: In
            values:
            - services

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[usualstuff]

The issue is still present in version 3.3.2

[usmonster]

I guess something went wrong in #4265? If so, it seems like a straightforward fix, yes?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[usmonster]

@rjkernick @tsiddique, can you please confirm this is an issue? It seems to be an easy fix. Thanks!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[stale]

This issue is being automatically closed due to inactivity.