Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/jenkins] Make PrometheusRule Namespace configurable #23306

Closed
fl-max opened this issue Jul 22, 2020 · 3 comments
Closed

[stable/jenkins] Make PrometheusRule Namespace configurable #23306

fl-max opened this issue Jul 22, 2020 · 3 comments

Comments

@fl-max
Copy link

fl-max commented Jul 22, 2020

Is your feature request related to a problem? Please describe.
By default, and without customizations, Prometheus only looks for PrometheusRules and ServiceMonitors in its own Namespace. Currently, the ServiceMonitor Namespace is configurable but the PrometheusRule is not.

Describe the solution you'd like
Add support to allow PrometheusRule to be configured via .Values.master.prometheus.prometheusRuleNamespace

Example:

{{- if .Values.master.prometheus.prometheusRuleNamespace }}
  namespace: {{ .Values.master.prometheus.prometheusRuleNamespace }}
{{- else }}
  namespace: {{ template "jenkins.namespace" . }}
{{- end }}

Also, add these to the values.yaml file and Document them.

Describe alternatives you've considered
Modifying Prometheus to scan other Namespaces

Additional context

@torstenwalter
Copy link
Collaborator

@fl-max I like you suggestion. Could you create a PR for that?

@stale
Copy link

stale bot commented Sep 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2020
@scottrigby
Copy link
Member

📢 stable/jenkins has moved to https://github.com/jenkinsci/helm-charts. If still applicable, please reopen the issue there. Thanks!

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants