[stable/prometheus] cannot set server.enableServiceLinks using helm@3

[bfmiv]

Describe the bug

Setting server.enableServiceLinks yields no result.

Version of Helm and Kubernetes:

$ k version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.8", GitCommit:"9f2892aab98fe339f3bd70e3c470144299398ace", GitTreeState:"clean", BuildDate:"2020-08-13T16:12:48Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.8", GitCommit:"9f2892aab98fe339f3bd70e3c470144299398ace", GitTreeState:"clean", BuildDate:"2020-08-13T16:04:18Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}

$ helm version
version.BuildInfo{Version:"v3.2.4", GitCommit:"0ad800ef43d3b826f31a5ad8dfbb4fe05d143688", GitTreeState:"clean", GoVersion:"go1.13.12"}

Which chart:

stable/prometheus

What happened:

I am running into prometheus/prometheus#7286 and need to set server.enableServiceLinks=false. It seems the field used to check k8s version here (.Capabilities.KubeVersion.GitVersion) was removed in helm@3.

The equivalent field in helm@3 is .Capabilities.KubeVersion.Version.

What you expected to happen:

enableServiceLinks should be rendered in deployment / stateful set

How to reproduce it (as minimally and precisely as possible):

helm template stable/prometheus --set server.enableServiceLinks=false | grep enableServiceLinks

Anything else we need to know:

• [stable/prometheus] Disable "enableServiceLinks" on Kubernetes prior 1.13 #23299
• https://helm.sh/docs/chart_template_guide/builtin_objects/
• https://v2.helm.sh/docs/chart_template_guide/#built-in-objects

[bfmiv]

Also - just noticed that the enableServiceLinks logic is missing entirely from the deployment template.

[gkarthiks]

Hi @bfmiv the stable/prometheus chart has been deprecated effectively as per this PR #23692 on Sep 5, 2020 and moved to https://github.com/prometheus-community/helm-charts.

Please close this Issue and re-open against the prometheus-community/helm-charts repo. Here's a friendly link for new issue

We hope to see you there. 👋