Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Airflow Chart #2591

Closed
gsemet opened this issue Oct 25, 2017 · 35 comments
Closed

Airflow Chart #2591

gsemet opened this issue Oct 25, 2017 · 35 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@gsemet
Copy link
Contributor

gsemet commented Oct 25, 2017

Hello

I am working on an Helm Chart for Kubernetes. You can find my proposal on kube-airflow#16. I plan to use this project to land it first, and then prepare a clean Helm chart here if you agree. I see plenty of pending Pull Request on this project, can I get some hints on how to help the integration ?

@unguiculus
Copy link
Member

Don't hesitate to create a PR for a new chart. Make sure you follow best practices. If you use helm create with Helm 2.7+ you'll get an initial experience with current best practices applied.

https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md
https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2018
@gsemet
Copy link
Contributor Author

gsemet commented Jan 28, 2018

I still want to work on it. The change I needed has been integrated into airflow mainline, so I can now make the official PR to helm :)

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 27, 2018
@gsemet
Copy link
Contributor Author

gsemet commented Feb 27, 2018

damned! Please so not close it yet, we are almost ready to publish :)

@knuckolls
Copy link

fwiw i am willing to be a beta tester of this helm chart as we are likely about to go all in on an airflow / kube stack.

@gsemet
Copy link
Contributor Author

gsemet commented Feb 27, 2018

Hi. You can have a look at this version: gh:gsemet/kube-airflow@helm_chart.

@gsemet
Copy link
Contributor Author

gsemet commented Mar 2, 2018

I am aligning the Helm chart in gh:gsemet/kube-airflow (master branch) with the WIP I am submitting here in #3959. Still some work to do.

@techdiverdown
Copy link

I would be interested in testing as well as we are moving to airflow on K8.

@gsemet
Copy link
Contributor Author

gsemet commented Mar 20, 2018

Feel free to test and give me your feedback !

@maver1ck
Copy link
Collaborator

Same in my situation.

@rolanddb
Copy link

rolanddb commented Apr 6, 2018

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 6, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2018
@gsemet
Copy link
Contributor Author

gsemet commented Jul 5, 2018

For me the mergerequest is ready to merge. Need an approver

@maver1ck
Copy link
Collaborator

maver1ck commented Jul 9, 2018

Are we going to merge this ?

@timshoaf
Copy link

timshoaf commented Jul 9, 2018

Would really love to see this included.

@maver1ck
Copy link
Collaborator

maver1ck commented Aug 6, 2018

@unguiculus ?

@stale
Copy link

stale bot commented Aug 20, 2018

This issue is being automatically closed due to inactivity.

@stale stale bot closed this as completed Aug 20, 2018
@gsemet
Copy link
Contributor Author

gsemet commented Aug 20, 2018

Hello. Can you please reopen it ? This pull request is pretty stable and used in production, and is ready to be merged. Please someone review it ?

@maver1ck
Copy link
Collaborator

@rolanddb ?

@rolanddb
Copy link

/remove-lifecycle stale

@rolanddb
Copy link

Not sure if this will work.

I am not in a position to merge this or reopen it. I do not maintain this repo.

I've personally put quite some effort in the chart and would like to see it merged. But I'm not sure what it will take to convince someone to merge it.

@gsemet
Copy link
Contributor Author

gsemet commented Aug 24, 2018

sadly i do not get anyone to review this pull request :(

@ttelfer
Copy link

ttelfer commented Oct 4, 2018

Our company is interested in pursuing Airflow+kubernetes. Could someone describe to me how I would got about testing this branch? @gsemet

@gsemet
Copy link
Contributor Author

gsemet commented Oct 4, 2018

Hi. You can download (git clone) it and use with helm directly (as I do in my compagny)

@ttelfer
Copy link

ttelfer commented Oct 4, 2018

@gsemet Would you be able to describe how to get helm to install airflow from the repo that was cloned. I attempted to run from the root of your cloned repo:

helm install --namespace "airflow" --name "airflow" incubator/airflow

and received the error:

Error: found in requirements.yaml, but missing in charts/ directory: postgresql, redis

Any suggestions?

@gsemet
Copy link
Contributor Author

gsemet commented Oct 4, 2018

it it not yet merged so it is not in incubator/airflow (not sure if it test file existant first).

You need to clone and then use helm install ... ./charts/incubator/airflow/ (maybe you need helm dependency build charts/incubator/airflow)

@dazza-codes
Copy link

dazza-codes commented Nov 27, 2018

/remove-lifecycle stale
/remove-lifecycle rotten

@gsemet
Copy link
Contributor Author

gsemet commented Nov 27, 2018

+1

3 similar comments
@barakyo
Copy link

barakyo commented Dec 3, 2018

+1

@paulyhedral
Copy link

+1

@pre-rendered
Copy link

+1

@gsemet
Copy link
Contributor Author

gsemet commented Dec 4, 2018

Please vote on the MR, it is almost ready :) do not hesitate to test latest version and tell if you use it in production !

@limnick
Copy link

limnick commented Dec 13, 2018

+1

@gsemet
Copy link
Contributor Author

gsemet commented Dec 22, 2018

Chart is now merged :) Thanks for all your help !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests