[stable/prometheus] Add extraHostPathMounts config to alert manager #1377
Conversation
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
k8s-ci-robot
added
cncf-cla: yes
|
Hi @nlamirault. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| - name: {{ .name }} | ||
| mountPath: {{ .mountPath }} | ||
| readOnly: {{ .readOnly }} | ||
| {{-end}} |
There was a problem hiding this comment.
Nit: let's move the conditionals in one level (that is, one less indent)
| - name: {{ .name }} | ||
| hostPath: | ||
| path: {{ .hostPath }} | ||
| {{-end}} |
There was a problem hiding this comment.
Nit: let's move the conditionals in one level (that is, one less indent)
|
@k8s-bot ok to test |
k8s-ci-robot
removed
the
needs-ok-to-test
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
|
/retest |
|
@nlamirault: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@nlamirault looks like you committed a new |
|
Marking this as stale. Please update within one week. |
|
Closing as stale. Feel free to re-open if/when you have the opportunity. |
Like this PR #862
Signed-off-by: Nicolas Lamirault nicolas.lamirault@gmail.com