Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus] Add extraHostPathMounts config #862

Merged
merged 2 commits into from
Jun 2, 2017
Merged

[stable/prometheus] Add extraHostPathMounts config #862

merged 2 commits into from
Jun 2, 2017

Conversation

yuanying
Copy link
Contributor

  • Add nodeExporter.extraHostPathMounts to prometheus

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @yuanying. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuanying yuanying force-pushed the node-exporter-support-extra-mounts branch from 2498eee to 72c57c7 Compare March 27, 2017 05:23
@yuanying
Copy link
Contributor Author

Hi, I want to use textfile collector for node-exporter. But currently it seems that there are no way to share textfile metrics data between other pod which collect another metrics.

So, how about to add extraMounts option to node-exporter to share such data?

@mgoodness mgoodness self-assigned this Apr 13, 2017
@yuanying yuanying force-pushed the node-exporter-support-extra-mounts branch 3 times, most recently from d08cffa to 29a2fa3 Compare April 14, 2017 07:40
@mgoodness
Copy link
Contributor

@k8s-bot ok to test

mgoodness
mgoodness suggested changes May 30, 2017
View reviewed changes
stable/prometheus/values.yaml Outdated
@@ -214,6 +214,14 @@ nodeExporter:
##
extraArgs: {}

## Additional node-exporter extra hostPath mounts
##
extraHostPathMounts: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this array documented in the chart's README.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing.
I have added document to README.

stable/prometheus/values.yaml Outdated
@@ -271,6 +279,14 @@ server:
##
extraArgs: {}

## Additional server extra hostPath mounts
##
extraHostPathMounts: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be added to the chart's README.

@yuanying
[stable/prometheus] Add extraHostPathMounts config
8ad9ab7 
* Add nodeExporter.extraHostPathMounts to prometheus
* Add server.extraHostPathMounts to prometheus
@yuanying yuanying force-pushed the node-exporter-support-extra-mounts branch from 29a2fa3 to 8ad9ab7 Compare May 31, 2017 04:36
@mgoodness mgoodness added lgtm Indicates that a PR is ready to be merged. and removed changes needed labels Jun 2, 2017
@mgoodness mgoodness merged commit de9232b into helm:master Jun 2, 2017
lachie83 added a commit to lachie83/charts that referenced this pull request Jun 2, 2017
@lachie83
Merge remote-tracking branch 'upstream/master'
bbdfb4d 
* upstream/master:
  Add Fluent Bit chart. (helm#895)
  Existing PVC support for stable/drupal (helm#1084)
  [stable/nginx-ingress] - Adding in support for the publish-service parameter (helm#975)
  [stable/prometheus] Add extraHostPathMounts config (helm#862)
@nlamirault nlamirault mentioned this pull request Jun 26, 2017
Closed
yanns pushed a commit to yanns/charts that referenced this pull request Jul 28, 2017
@yuanying @mgoodness
[stable/prometheus] Add extraHostPathMounts config (helm#862)
0a44f91 
* [stable/prometheus] Add extraHostPathMounts config

* Add nodeExporter.extraHostPathMounts to prometheus
* Add server.extraHostPathMounts to prometheus

* Tweak indentation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgoodness mgoodness mgoodness approved these changes

Assignees

@mgoodness mgoodness

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuanying @k8s-ci-robot @mgoodness