Skip to content

Commit

Permalink
Note that helm lint should warn about git deps
Browse files Browse the repository at this point in the history
Signed-off-by: Dominykas Blyžė <hello@dominykas.com>
  • Loading branch information
dominykas committed Dec 15, 2023
1 parent 4fc29f1 commit c16a922
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions hips/hip-00NN.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ dependencies:
version: "main"
```

### Installation

When Helm is installing a dependency from git, it should:

- create a temporary directory
Expand All @@ -64,6 +66,10 @@ When Helm is installing a dependency from git, it should:
- treat the cloned git repo similar to a `file:///path/to/temp/dir` style requirement; use `chart.LoadDir` to load that directory (which in turn applied the logic for filtering the files through `.helmignore`) and archives it to `charts/`
- delete the temp dir

### Linting

`helm lint` should print a warning when a chart contains a git-based dependency, primarily because git references are mutable.

## Backwards compatibility

This is backwards compatible from Helm perspective - the existing formats for `dependencies` are still supported.
Expand Down

0 comments on commit c16a922

Please sign in to comment.