Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm 3: Add new chart version reference system based on Docker #65

Closed
wants to merge 3 commits into from

Conversation

jdolitsky
Copy link
Contributor

As discussed in Helm 3 repos meeting and on cncf-helm mailing list.
Notes here: https://hackmd.io/6cEbLF6DQlyGtUbsJAKQzg

This is essentially the only breaking change we need to make in order to be able to implement things like #55 behind the scenes post-3.0.0.

The schedule of that project, as well as related things such as helm push, helm login should not affect the Helm 3 schedule as these can be layered in as features in Helm 3.1/3.2/3.3 if necessary.

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
@helm-bot helm-bot added size/M and removed size/M labels Nov 30, 2018
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
Copy link

@stefsuse stefsuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it. will let a maintainer hit the real approval button..

helm-v3/001-charts.md Outdated Show resolved Hide resolved
helm-v3/001-charts.md Outdated Show resolved Hide resolved
Immutability, or "releases" as defined by
[App Registry](https://github.com/app-registry/appr/blob/master/Documentation/quick-start.md),
can be added at a later date without introducing any breaking changes by updating the version reference system to
accept additional characters (e.g. `@1.0.0`).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what other characters besides '-' are needed? Ex 4.0.0-alpha1
I can't think of a reason why you would want to type for example, helm install stable/chart-~1.0.1 when you know that chart-1.0.1 is stable for your needs. Unless I just totally read this wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefsuse take a look at what app registry does in regards to releases vs channels: https://github.com/app-registry/appr/blob/master/Documentation/quick-start.md

By other characters, I mean separators between name and version that are not : (e.g. @ to specify an immutable release)

What comes after the : character is the chart version, and that format will comply with whatever version validation is already in place

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
@jdolitsky
Copy link
Contributor Author

Closing this, will open another PR with a general summary of updates needed

@jdolitsky jdolitsky closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants