-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm 3: Add new chart version reference system based on Docker #65
Conversation
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
c325928
to
3f9a083
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do it. will let a maintainer hit the real approval button..
Immutability, or "releases" as defined by | ||
[App Registry](https://github.com/app-registry/appr/blob/master/Documentation/quick-start.md), | ||
can be added at a later date without introducing any breaking changes by updating the version reference system to | ||
accept additional characters (e.g. `@1.0.0`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what other characters besides '-' are needed? Ex 4.0.0-alpha1
I can't think of a reason why you would want to type for example, helm install stable/chart-~1.0.1
when you know that chart-1.0.1 is stable for your needs. Unless I just totally read this wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefsuse take a look at what app registry does in regards to releases vs channels: https://github.com/app-registry/appr/blob/master/Documentation/quick-start.md
By other characters, I mean separators between name and version that are not :
(e.g. @
to specify an immutable release)
What comes after the :
character is the chart version, and that format will comply with whatever version validation is already in place
14a0c7f
to
0a35a69
Compare
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
0a35a69
to
68bb2a2
Compare
Closing this, will open another PR with a general summary of updates needed |
As discussed in Helm 3 repos meeting and on cncf-helm mailing list.
Notes here: https://hackmd.io/6cEbLF6DQlyGtUbsJAKQzg
This is essentially the only breaking change we need to make in order to be able to implement things like #55 behind the scenes post-3.0.0.
The schedule of that project, as well as related things such as
helm push
,helm login
should not affect the Helm 3 schedule as these can be layered in as features in Helm 3.1/3.2/3.3 if necessary.