-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release.Namespace and Release.Time in charts repo but missing from Helm v3 #5732
Comments
ref: helm#5732 Signed-off-by: Adam Reese <adam@reese.io>
So
|
There aren't many public uses of
Once we do those two things we can close this out unless I missed something. |
@technosophos So... everyone is using If we add a function to sprig there will be many using a version of Helm that doesn't support this. Sadly, lots of people use old helm versions. Not sure if they are using this part of release. I created Masterminds/sprig#164 to give sprig the ability to do this. |
Are there action items we should be addressing for Helm 3, or is this safe to close with the sprig bump? |
perhaps this should be closed in favour of #5733 if that's the last action item to close this one out. |
closing in favour of #5733. |
@technosophos, but isn't there a risk that Was not the |
Also, is there a way of getting a consistent random value that would work equally through all templates (without writing a new helper and defining variables in global scope)? |
The dev-v3 branch, as of c62a3a4, no longer has
.Release.Namespace
and.Release.Time
available in templates. It appears this was changed in aa859e3 in order to "make template rendering discrete and repeatable".There are some problems with this.
.Release.Time
here and.Release.Namespace
here. These charts won't work with Helm v3.Release.Namespace
is needed for RBAC. Removing it hinders the ability of a chart to create RBAC config. See the comment on the commit and how it's used in the charts repo. Removal of namespace limits what charts can be used forThis was referenced in #4255 (comment) where @adamreese said it would be added back.
cc @bacongobbler @adamreese
The text was updated successfully, but these errors were encountered: