Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Filter list response with unique results #571

Merged
merged 5 commits into from
Dec 5, 2018

Conversation

andresmgot
Copy link
Contributor

Signed-off-by: Andres Martinez Gotor andres@bitnami.com

Ref: #570

Return unique charts by digest when listing.

cc/ @prydonius

Andres Martinez Gotor added 2 commits December 5, 2018 16:05
Signed-off-by: Andres Martinez Gotor <andres@bitnami.com>
Signed-off-by: Andres Martinez Gotor <andres@bitnami.com>
@helm-bot helm-bot added the size/M label Dec 5, 2018
Signed-off-by: Andres Martinez Gotor <andres@bitnami.com>
@helm-bot helm-bot added size/M and removed size/M labels Dec 5, 2018
Copy link
Member

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @andresmgot, this is looking good - just have a few minor suggestions.

cmd/chartsvc/handler.go Outdated Show resolved Hide resolved
cmd/chartsvc/handler.go Outdated Show resolved Hide resolved
cmd/chartsvc/handler.go Outdated Show resolved Hide resolved
cmd/chartsvc/handler.go Outdated Show resolved Hide resolved
cmd/chartsvc/handler_test.go Show resolved Hide resolved
Signed-off-by: Andres Martinez Gotor <andres@bitnami.com>
@helm-bot helm-bot added size/M and removed size/M labels Dec 5, 2018
Copy link
Member

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after these minor suggestions

cmd/chartsvc/handler.go Show resolved Hide resolved
cmd/chartsvc/handler_test.go Outdated Show resolved Hide resolved
@helm-bot helm-bot added size/M and removed size/M labels Dec 5, 2018
Signed-off-by: Andres Martinez Gotor <andres@bitnami.com>
Copy link
Contributor

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andresmgot!

@prydonius prydonius merged commit 30adcb3 into helm:master Dec 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants