Export a function that takes a res and sets the headers

[satazor]

There are cases where we simply want to set the nocache headers in a handler, depending on some condition. Using this as a middleware on those cases is not as convenient. We can get around it but it's ugly:

// If no cache-control headers are still defined, default to no-cache
if (res.get('cache-control')) {
    nocache()(null, res, () => {});
}

// some more code

..instead it would be cool to do:

// If no cache-control headers are still defined, default to no-cache
if (res.get('cache-control')) {
    nocache.setHeaders(res);
}

// some more code

(the name of the method can obviously be more appropriate).

Would you be willing to provide this functionality?

[EvanHahn]

Conditional application of Express middleware is a problem that's plagued Helmet and Express in general. Would something like this work for you?

app.get('/some-route',
  function (req, res, next) {
    if (res.get('cache-control')) {
      nocache()(null, res, next);
   } else {
     next();
   },
   function (req, res) {
     res.send('this is the response');
   }
);

[satazor]

Your solution is perfectly valid, I was just hoping to make it less clunky.

[EvanHahn]

I don't want to add something to Helmet (conditional middleware) that I feel should really be added to Express. (I've tried a few times to write a generalized conditional middleware package but have been unable to find something much less clunky than my solution above.)

Is it okay if I close this issue?

[satazor]

👍

[EvanHahn]

Feel free to open a new issue if you run into anything else!