Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Pragma Header #25

Closed
dani2819 opened this issue May 31, 2023 · 5 comments
Closed

Removal of Pragma Header #25

dani2819 opened this issue May 31, 2023 · 5 comments
Assignees

Comments

@dani2819
Copy link
Contributor

It has come to my attention that the Pragma header is no longer recommended as per the latest web standards and may already have been removed, be in the process of being dropped, or only kept for compatibility purposes. For more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Pragma

The Pragma header was initially used to provide backward compatibility with HTTP/1.0 caches. However, with the widespread adoption of HTTP/1.1 and the introduction of cache-control directives, the Pragma header has become obsolete. The cache-control directives such as "no-cache" and "no-store" are now the standard mechanisms for controlling caching behavior.

I think in order to align with the latest web standards and best practices by removing the usage of the Pragma header from the library.

Please let me know about your opinions? I am happy to make a PR :)

@EvanHahn
Copy link
Member

Good idea.

Feel free to make a PR! Because this is a breaking change, please open it against the v4 branch that I just created.

@dani2819
Copy link
Contributor Author

@EvanHahn I couldn't be able to push the implementation because of lack of permissions.

ERROR: Permission to helmetjs/nocache.git denied to dani2819.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@EvanHahn
Copy link
Member

Could you fork the repository and push to your fork?

@dani2819
Copy link
Contributor Author

@EvanHahn oh yes, here you go: #26

@EvanHahn
Copy link
Member

EvanHahn commented Jun 1, 2023

This has been deployed in nocache@4.0.0.

@EvanHahn EvanHahn closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants