Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide action output with the ccache path? #101

Open
vadz opened this issue Sep 25, 2022 · 0 comments
Open

Provide action output with the ccache path? #101

vadz opened this issue Sep 25, 2022 · 0 comments

Comments

@vadz
Copy link
Contributor

vadz commented Sep 25, 2022

The documentation currently recommends doing

    export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"

which works, but seems a bit ugly as we use a directory in the path which doesn't exist on the current platform and not very future-proof as this will stop working when/if GitHub provides CI runners on ARM-based Macs, where we'd have to add /opt/homebrew/opt/ccache/libexec to the path instead. And the not nice thing is that this won't result in an error, but ccache will just silently not be used, until all workflows using this action are updated to use the new path.

So I wonder if it would make sense to have an output in this action with the directory to prepend to the path? It looks like it would be easy to do and I could probably do this myself if you agree that this is a good idea.

Alternatively, and even more conveniently, if also more magically, perhaps the action should just update the PATH on its own? Or is writing to $GITHUB_ENV from an action disallowed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant