Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Use hyper-tab-icons internally? #8

Open
TrevorBurnham opened this issue Feb 27, 2017 · 3 comments
Open

Use hyper-tab-icons internally? #8

TrevorBurnham opened this issue Feb 27, 2017 · 3 comments

Comments

@TrevorBurnham
Copy link

The hyper-tab-icons plugin supports a more comprehensive set of icons, as well as more mappings for alternative process names and support for custom mappings.

I like the other enhancements provided by hyper-tabs-enhanced, so I wonder if it would be possible for this project to integrate hyper-tab-icons, rather than compete with it for the same functionality.

@henrikruscon
Copy link
Owner

@TrevorBurnham

Problem with just dropping support for tab icons in favor of hyper-tab-icons is that people would have to find both plugins. Since there's currently no easy way to have a plugin depend on another. If hyper-tab-icons creator were open to merge the plugins I wouldn't mind collaborating on that.

If there's any icons you're missing I'll gladly add them, just let me know ✌️

PR #6 adds support for mapping, I just haven't had time to fully look at it and I also want to refactor some of that code before merging.

@dfrankland
Copy link

I can expose an API for this plugin to consume if it makes things easier.

@ELLIOTTCABLE
Copy link

Why, precisely, should this depend on hyper-tab-icons? Honestly, this could/should be smaller and more granular, provide less functionality. Users can find the other package if they want that specific functionality.

Seems to me that a mention in the README (as with the status-line mention, etc) is more than enough? Just my 2¢.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants