Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actor_log_prob.transpose in MPO causes error #10

Closed
zhaoyi11 opened this issue Nov 15, 2021 · 1 comment
Closed

actor_log_prob.transpose in MPO causes error #10

zhaoyi11 opened this issue Nov 15, 2021 · 1 comment

Comments

@zhaoyi11
Copy link

Hi,

Thanks so much for the clean implementation. In MPO, using actor_log_prob.transpose((0, 1)) causes error.

actor_log_prob = actor_log_prob.transpose((0, 1))

TypeError: transpose permutation isn't a permutation of operand dimensions, got permutation (0, 1) for operand shape (256, 20, 1).

I checked the shape of actor_log_prob and weights, they are in the same shape. After removing this line, I can get the samilar performance in cartpole_swingup env as shown in README.md.

Best,
Yi

@henry-prior
Copy link
Owner

Looks like this line was unnecessary, removed it in #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants