Add a Cast icon for the context menu

[rodrigoswz]

Perhaps the minor and least important issue of this amazing project...

I just wanted to request to add an icon in the context menu because currently the option mixes with the other extensions and causes a certain strangeness. It's it.

[hensm]

Late response, sorry.

Yeah, the only reason I didn't add the icon already was because it looked weird against dark themes. The menu icon itself isn't such a big problem, since only Firefox on Linux has dark menus, but it can't be set independently of the extension icon which appears against multiple dark backgrounds.

Could use a different colour until they support theme-specific icons, I suppose?

[rodrigoswz]

I understand, for now, a different color looks good to me, if you agree ofc.

But, Open in Sidebar is an extension on my browser that can do this, note my first comment with light theme and now see how the icon of this extension looks in the dark theme:

I haven't found the source code for that extension though (if that is open source).

[hensm]

Seems to inherit its fill colour from the browser stylesheet, but this is only enabled for internal URLs and Mozilla extensions by default. Do you have svg.context-properties.content.enabled flipped, by any chance? I could make it so it falls back to the blue, so anyone with it enabled would see the correct colours.

Turns out prefers-color-scheme works in icon SVGs now, so that's also an option. But it breaks on anything but the default theme and probably doesn't work on Linux (e: or in fact macOS/Windows, since the context menus don't match the dark theme yet, so it's not really an option except for the add-ons page).

Just a matter of picking the least worst solution,