Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fx cast Extension UI showing where to chromecast, but all options are grayed out #139

Closed
TimeBomb opened this issue Aug 19, 2020 · 7 comments

Comments

@TimeBomb
Copy link

image

This is affecting both my Windows 10 machine, and a friend's Mac OS X machine, latest version of Firefox and Windows/Mac. The bridge is working fine. The API works fine - I can whitelist and cast youtube successfully through the youtube player. But this UI isn't working, all the buttons are grayed out for an unknown reason.

@hensm
Copy link
Owner

hensm commented Aug 19, 2020

Tab/Screen casting is disabled by default, so those are greyed out. The app option is disabled because there's no initialized sender app on the current page. Tab is selected because that's the default option when the selector is launched via the menu or toolbar button, but because there's no valid selection, the cast buttons are disabled.

I really need to make this more intuitive... welcoming any suggestions.

@TimeBomb
Copy link
Author

Ah gotcha that makes sense, thanks for the heads up and for the quick reply. I'm looking through the browser extension options and don't see a way to enable tab/screen casting. How does one go about enabling that?

@hensm
Copy link
Owner

hensm commented Aug 19, 2020

Listed as screen mirroring. Performance may not be fantastic, though, that's why it's disabled (see #132).

screen

@TimeBomb
Copy link
Author

Hm I see what you're saying. Thanks for the info.

Few thoughts:

  1. As a user, I think of these features as "casting a tab" and "casting my screen", rather than "mirroring my screen". So maybe something like "Enable tab & screen casting" instead of "Enable screen mirroring"?

  2. Maybe a brief note in the Settings mentioning that the feature has performance issues

  3. Similarly, a brief note in the Extension's Cast UI that screen and tab casting is disabled by default, and to enable it in settings. Or better yet, allow the user to click something in the cast UI that allows them to enable the feature from that window.

My current expected norm with casting is the ability to cast tabs and screens, so if it's disabled by default, the more up front information that it's disabled by default, the less confused I am as a user.

The extension's awesome btw, thanks for the hard work!

@rimrul
Copy link
Contributor

rimrul commented Aug 20, 2020

How about a hint as to why an option is greyed out? Like

  • This sites app (not found)
  • Tab (disabled)
  • Screen (disabled)

That might be enough to lead most people in the right direction.

@hensm
Copy link
Owner

hensm commented Aug 20, 2020

@TimeBomb
Mirroring is labelled as "Screen/tab casting" and the enable option is tagged as experimental.
864cde8, fa0cf0a

Since discoverability isn't useful unless the feature is worth using, I might just remove the mirroring options from the list entirely unless it's enabled. Some sort of hint seems appropriate when there's no valid state, and not allowing disabled options to be selected initially.

@TimeBomb
Copy link
Author

Fantastic, thanks a lot!

@hensm hensm closed this as completed in 6960508 Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants