Log client/server versions before starting tests. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mml
added a commit
to mml/k8s-conformance
that referenced
this pull request
Oct 2, 2017
Added to kube-conformance in heptio/kube-conformance#6.
|
@mml Why not put this into upstream also? We can cherry pick onto 1.8 and pull downstream until upstream produces a e2e container that is not kubekins. Also, sonobuoy already reports this https://github.com/heptio/sonobuoy/blob/master/docs/img/snapshot-00-overview.png in the serverversion.json file. |
|
I can find a place for it upstream, but in the meantime, I'd like this to start working even with 1.7. Putting it here for the moment ensures it works with all test images. I can leave a As for already reporting this, we don't report the version of the e2e.test binary. That's what we're asking reviewers to compare. |
timothysc
approved these changes
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had thought e2e.test outputted this, but it does not.
kubetestdoes, and I think once this image is generated as a release artifact, we should just switch to usingkubetest.