Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting service doesn't run the latest service #34

Open
domenkozar opened this issue Apr 24, 2019 · 4 comments
Open

Restarting service doesn't run the latest service #34

domenkozar opened this issue Apr 24, 2019 · 4 comments
Labels
bug Something isn't working needs-documentation wontfix This will not be worked on

Comments

@domenkozar
Copy link
Contributor

domenkozar commented Apr 24, 2019

Reproduce

Given arion container as:

    web = {
      service.useHostStore = true;
      service.depends_on = [ "hercules-server" ];
      service.ports = [
        "8088:80"
      ];
      nixos.useSystemd = true;
      nixos.configuration = {
        imports = [ ../../web/module.nix ];
        services.hercules-web = {
          domain = envConfig.domain;
          backend = apiInternalURL;
        };
      };
    };

When there's a change in the closure of the nixos system,
arion restart web will rebuild all the changes, but they won't be in effect which is confusing.

Workaround

arion up -d --always-recreate-deps web will recreate the image.

@domenkozar
Copy link
Contributor Author

Maybe service.useHostNixDaemon should be set to true as well?

@domenkozar domenkozar added the bug Something isn't working label Apr 30, 2019
@roberth
Copy link
Member

roberth commented May 1, 2019

service.useHostNixDaemon is only relevant if you want to run nix-build inside the container. I don't think that applies here.

@roberth
Copy link
Member

roberth commented May 1, 2019

It's a Docker Compose footgun we've inherited.

If you make changes to your docker-compose.yml configuration these changes are not reflected after running this command.

The "correct" command seems to be up -d

@roberth
Copy link
Member

roberth commented May 1, 2019

This does seem to indicate that we only need to evaluate the composition - not build it.

@roberth roberth added needs-documentation wontfix This will not be worked on labels May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-documentation wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants