Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "impurities" #13

Open
roberth opened this issue Aug 21, 2019 · 2 comments
Open

The "impurities" #13

roberth opened this issue Aug 21, 2019 · 2 comments
Assignees

Comments

@roberth
Copy link
Member

roberth commented Aug 21, 2019

  • Investigate whether paths in the store are valid arguments and need to be treated differently.

  • Put in the README something like:

gitignore uses home, which can be considered "impure", but is your worktree really "pure" without ignoring your local tools' mess?

@roberth roberth self-assigned this Aug 21, 2019
@lorenzleutgeb
Copy link

I came here trying to figure out whether this library works with Flakes and pure builds. This issue seems to indicate that it doesn't, mentioning home. Maybe add a sentence to README.md about purity?

@roberth
Copy link
Member Author

roberth commented Mar 29, 2021

My understanding is that pure mode will pretend home does not exist, which is handled gracefully.

I can't confirm this because for some reason pure-eval seems to enable restricted mode as well and it's unable to load the very file I'm asking it to build. Maybe you'll have more luck.

I should also note that flakes invoke builtins.fetchGit and then import from there which kind of works but has drawbacks as well. Using gitignore.nix with flakes may be redundant, unless you're exporting functions that will be used in a non-flake context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants