Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp.conf: Add "ntpsigndsocket" #516

Closed
pmhahn opened this issue Oct 27, 2017 · 1 comment
Closed

ntp.conf: Add "ntpsigndsocket" #516

pmhahn opened this issue Oct 27, 2017 · 1 comment

Comments

@pmhahn
Copy link

pmhahn commented Oct 27, 2017

ntp.org Bug 1028 added the "ntpsignedsocket" statement to configures cryptographic signed NTP. It is missing in the documentation.
If it exists, augeas fails to parse /etc/ntp.conf
The following patch fixes it:

From 54de8c5ba8ec54502eb797801b22d657cb7ffcdc Mon Sep 17 00:00:00 2001
Message-Id: <54de8c5ba8ec54502eb797801b22d657cb7ffcdc.1509107883.git.hahn@univention.de>
From: Philipp Hahn <hahn@univention.de>
Date: Fri, 27 Oct 2017 14:05:07 +0200
Subject: [PATCH] ntp.conf: Add "ntpsigndsocket" #516
Organization: Univention GmbH, Bremen, Germany

ntp.org Bug 1028 <http://bugs.ntp.org/show_bug.cgi?id=1028>  added the
"ntpsignedsocket" statement to configures cryptographic signed NTP:

> commit 4480a3070bb07cc09e095d8eec974dbf3c3f4d50
> Author: stenn@whimsy.udel.edu
> Date: Tue Dec 23 04:34:32 2008 -0500
> [Bug 1028] Support for W32Time authentication via Samba

It is missing in the documentation. If it exists, augeas fails to parse
/etc/ntp.conf
---
 lenses/ntp.aug            | 1 +
 lenses/tests/test_ntp.aug | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/lenses/ntp.aug b/lenses/ntp.aug
index c11d5c0b..33e2eabc 100644
--- a/lenses/ntp.aug
+++ b/lenses/ntp.aug
@@ -62,6 +62,7 @@ module Ntp =
       | flags
       | simple_setting /driftfile|leapfile|logfile|includefile/
          | simple_setting "statsdir"
+         | simple_setting "ntpsigndsocket"
 
     (* Misc commands, see miscopt.html in ntp docs *)
 
diff --git a/lenses/tests/test_ntp.aug b/lenses/tests/test_ntp.aug
index f6aaa2de..2eea1d8a 100644
--- a/lenses/tests/test_ntp.aug
+++ b/lenses/tests/test_ntp.aug
@@ -19,6 +19,7 @@ restrict 127.0.0.1
 
 logfile /var/log/ntpd
 statsdir /var/log/ntpstats/
+ntpsigndsocket /var/lib/samba/ntp_signd
 
 statistics loopstats peerstats clockstats
 filegen loopstats file loopstats type day enable link
@@ -53,6 +54,7 @@ interface listen 127.0.0.1
       {}
       { "logfile"  = "/var/log/ntpd" }
       { "statsdir" = "/var/log/ntpstats/" }
+      { "ntpsigndsocket" = "/var/lib/samba/ntp_signd" }
       {}
       { "statistics"
          { "loopstats" }
-- 
2.11.0
@lutter lutter closed this as completed in 7dcc3c5 Oct 28, 2017
@lutter
Copy link
Member

lutter commented Oct 28, 2017

Nice find ! Thanks for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants