-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multipath.aug - unable to set "blacklist{ wwid .*}" #564
Comments
Hi, thanks for bringing this up. I just did a little checking with multipath 0.7.4 in Fedora 28, and it appears that wwid and devnode in the blacklist accept a ton more crazy stuff. At least,
So, should we just allow pretty much anything for wwid and devnode in the blacklist ? Do you know when the change to accept regexps there was introduced in multipath ? |
Hi,
I believe it was always using regexp, there was just a change in the parser. More info: |
Thanks for the additional detail. I put a slightly broader change into PR #565. Let me know if that works for you or not and I'll merge it. |
Looks good in my colleague testing. I've also done some manual testing and can confirm it fixes this issue. Thank You very much! What I found, is every time you want to blacklist a wwid using 'set', the existing one gets overwritten. This might not be a desired action if we're blacklisting one wwid at the time. Same behaviour with and without PR #565. |
You can do either. Using the
If there are already multiple
If there is no The simplest way to add a new one is
That will always create a new |
Thank You very much! |
The multipath lens is now accepting only asterisk, which works in older versions, but not with newer packages in Fedora for example. Snip from journalctl:
multipath[1205]: Jun 07 11:31:04 | Invalid regular expression "" in multipath.conf. Using "."
I propose a change in line 36, adding another OR, for ".*"
https://github.com/hercules-team/augeas/blob/master/lenses/multipath.aug#L36
from
let wwid = kv "wwid" (Rx.word|"*")
to
let wwid = kv "wwid" (Rx.word|"*"|".*")
The text was updated successfully, but these errors were encountered: