[asl] Change type of index in for loop #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadrienRenaud
force-pushed
the
asl-for-index-type
branch
from
510e57b
to
19fe008
Compare
HadrienRenaud
force-pushed
the
asl-for-index-type
branch
4 times, most recently
from
d4a4df3
to
1e1831d
Compare
HadrienRenaud
force-pushed
the
asl-for-index-type
branch
from
1e1831d
to
1dd0a7f
Compare
Roman-Manevich
added a commit
that referenced
this pull request
Aug 8, 2024
4 tasks
Roman-Manevich
added a commit
that referenced
this pull request
Aug 9, 2024
Roman-Manevich
added a commit
that referenced
this pull request
Aug 10, 2024
Roman-Manevich
added a commit
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the type of the index in a for loop. Before it was a complex operation to determine the maximum and the minimum of the bounds of the loop. Now the type of
iinfor i = a to bis simply:integer {a..b}ifaandbare well-constrained;TPositive8is now split in two:TPositive8keeps the bulk of the test. ASLRef does not report any error on this part after [asl] Iterate over possible values in domain. #926. For now, it still report a type error.TPositive8-1.