[asl] Iterate over possible values in domain. #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadrienRenaud
force-pushed
the
asl-iterate-on-possible-values
branch
4 times, most recently
from
0df9fd8
to
3f5c612
Compare
HadrienRenaud
force-pushed
the
asl-iterate-on-possible-values
branch
2 times, most recently
from
fb545c2
to
dd3f528
Compare
HadrienRenaud
added a commit
that referenced
this pull request
Aug 5, 2024
[asl] Change type of index in for loop
This PR changes the type of the index in a for loop. Before it was a complex operation to determine the maximum and the minimum of the bounds of the loop. Now the type of `i` in `for i = a to b` is simply:
- `integer {a..b}` if `a` and `b` are well-constrained;
- the unconstrained integer type otherwise.
`TPositive8` is now split in two:
- `TPositive8` keeps the bulk of the test. ASLRef does not report any error on this part after #926. For now, it still report a type error.
- ASLRef reports a type error on `TPositive8-1`.
HadrienRenaud
force-pushed
the
asl-iterate-on-possible-values
branch
from
dd3f528
to
8246f63
Compare
HadrienRenaud
force-pushed
the
asl-iterate-on-possible-values
branch
from
8246f63
to
bd616a5
Compare
Roman-Manevich
added a commit
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve subtype inference in cases where there is only a finite number of values, and we can iterate on them.