HARP-11250: Optional when conditions.

Changed the type of the `when` condition to be an optional style expression. This change is required to support style extensions. That is, a common use case of style extensions is to reference an existing style already having a `when` condition and set additional properties. Signed-off-by: Roberto Raggi <roberto.raggi@here.com>
heremaps · Aug 3, 2020 · 240cdd9 · 240cdd9
1 parent cc90020
commit 240cdd9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/@here/harp-datasource-protocol/lib/StyleSetEvaluator.ts b/@here/harp-datasource-protocol/lib/StyleSetEvaluator.ts
@@ -134,7 +134,7 @@ interface StyleInternalParams {
 type InternalStyle = Style & StyleInternalParams;
 
 /**
- * [[StyleConditionClassifier]] searches for usages of `$layer` in `when` conditions
+ * `StyleConditionClassifier` searches for usages of `$layer` in `when` conditions
  * associated with styling rules.
  *
  * @hidden

diff --git a/@here/harp-datasource-protocol/lib/Theme.ts b/@here/harp-datasource-protocol/lib/Theme.ts
@@ -293,7 +293,7 @@ export interface StyleAttributes<Technique, Params> {
      * Condition that is applied to feature properties to check if given {@link Style} this feature
      * should emit geometry of this style.
      */
-    when: string | JsonExpr;
+    when?: string | JsonExpr;
 
     /**
      * The layer containing the carto features processed by this style rule.