HARP-15183: Make standard technique's color modifiable at render time.

Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
heremaps · Apr 27, 2021 · b5c7a1a · b5c7a1a
1 parent 943588e
commit b5c7a1a
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/@here/harp-datasource-protocol/lib/TechniqueDescriptors.ts b/@here/harp-datasource-protocol/lib/TechniqueDescriptors.ts
@@ -245,7 +245,7 @@ const standardTechniqueDescriptor = mergeTechniqueDescriptor<StandardTechnique>(
     baseTechniqueParamsDescriptor,
     {
         attrDescriptors: {
-            color: AttrScope.FeatureGeometry,
+            color: { scope: AttrScope.TechniqueRendering, automatic: true },
             vertexColors: { scope: AttrScope.TechniqueRendering, automatic: true },
             wireframe: { scope: AttrScope.TechniqueRendering, automatic: true },
             roughness: { scope: AttrScope.TechniqueRendering, automatic: true },

diff --git a/test/rendering/StylingTest.ts b/test/rendering/StylingTest.ts
@@ -919,6 +919,29 @@ describe("MapView Styling Test", function () {
             });
         });
         describe("standard technique", function () {
+            mapViewFeaturesRenderingTest(`polygon-dynamic-color`, {
+                geoJson: {
+                    type: "FeatureCollection",
+                    features: [rectangle1, rectangle2, referenceBackground]
+                },
+                theme: {
+                    lights,
+                    styles: {
+                        geojson: [
+                            referenceBackroundStyle,
+                            {
+                                when: "$geometryType == 'polygon'",
+                                technique: "standard",
+                                attr: {
+                                    color: ["get", "dynamic-color", ["dynamic-properties"]]
+                                }
+                            }
+                        ]
+                    }
+                },
+                dynamicProperties: [{ name: "dynamic-color", value: "green" }]
+            });
+
             mapViewFeaturesRenderingTest(
                 `polygon-standard-texture`,
                 {